[MISC] (8.4/edge) Modernize Rock testing, take 2 - #41
Merged
Conversation
astrojuanlu
force-pushed
the
juanlu/modernize-rock-testing-take-2
branch
from
July 14, 2026 14:00
450bdd6 to
badfa57
Compare
astrojuanlu
marked this pull request as ready for review
July 14, 2026 14:30
astrojuanlu
added
the
not bug or enhancement
astrojuanlu
force-pushed
the
juanlu/modernize-rock-testing-take-2
branch
2 times, most recently
from
July 15, 2026 09:04
4859d90 to
7e9e8a2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
astrojuanlu
force-pushed
the
juanlu/modernize-rock-testing-take-2
branch
from
July 15, 2026 09:28
7e9e8a2 to
b10ab60
Compare
sinclert-canonical
approved these changes
Jul 15, 2026
astrojuanlu
force-pushed
the
juanlu/modernize-rock-testing-take-2
branch
from
July 15, 2026 12:50
9014381 to
11cdcb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar in spirit to canonical/mysql-snap#35.
This one is a bit more complicated because, as there's no official LXD VM backend in spread (canonical/spread#185, canonical/spread#286) and the QEMU one seems to be not very healthy (canonical/spread#140, canonical/spread#171), we have to jump through a few hoops to actually allocate LXD VMs from spread, which is needed to test our rock. #40 tried to use Podman inside LXD containers, without success.
This PR achieves separation between
rockcraft packandspread, meaning: you can run the tests without packing the artifact (or even try more novel approaches).To achieve that, I needed to:
.extensioncode (which is a craft-application construct)CRAFT_ARTIFACTmandatory env variable to pass the path to the rock to testgithub-cibackend, inspired by https://github.com/canonical/mysql-operators/blob/d454c6c8d199c60aa3a9e65cfedb26ebee35c1a5/machines/spread.yaml, that runs all the test operations directly on the host (kind of like "destructive mode"), to avoid having to allocate a LXD VMNotice that
spread/.extensionis not strictly needed anymore, but those scripts and instructions need to live somewhere anyway, I wanted to minimize the diff in this already sensitive PR.